Fix disabled ComboBox rendering to use system disabled palette in modern visual styles - #14843
Merged
LeafShi1 merged 1 commit intoAug 6, 2026
Conversation
LeafShi1
requested review from
KlausLoeffelmann,
SimonZhao888 and
ricardobossan
August 4, 2026 08:54
LeafShi1
force-pushed
the
Fix_14797_disabled_ComboBox_render_issue
branch
from
August 5, 2026 09:02
2ee1974 to
300b4c1
Compare
LeafShi1
force-pushed
the
Fix_14797_disabled_ComboBox_render_issue
branch
from
August 5, 2026 09:43
300b4c1 to
3688fd6
Compare
KlausLoeffelmann
approved these changes
Aug 5, 2026
KlausLoeffelmann
left a comment
Member
There was a problem hiding this comment.
It's just the one missing line - and I do not want to block this over that line, so, let's take this without addressing this. (The world will go on...)
But - let's make sure, we have a process, where we maintain both skills for code generation and code reviewing, so that those kinds of edits will be a thing of the past in a few months. 😸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14797
Root cause
ComboBox.ModernComboAdaptercomputed its disabled appearance by muting the control's ownBackColor/ForeColor ``(Mute(BackColor, 0.55f))rather than using a fixed system disabled palette. Because the muted result is derived from user colors, a ComboBox with a customBackColorstill looked "colored" when disabledSeparately, ComboBox did not handle
WM_CTLCOLORSTATICfor the native edit child. When disabled, Windows fell back to its default white background, which did not match the disabled surface the adapter painted for the rest of the field.Proposed changes
ModernControlColorMath(dark-mode and high-contrast aware) and makes the modern ComboBox adapter, the ComboBoxWM_CTLCOLORSTATIChandler, and the modern Button renderers all read from it, so disabled controls stay visually consistent.Customer Impact
Regression?
Risk
Screenshots
Before
Light mode:

Dark mode:

After
Light mode:

Dark mode:

Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow